Solved several issues discovered by me #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d static HTML elements classes
…t set. For now, no need to write \ at the start and end of the namespace. Example: (App\Component) instead of (\App\Component\).
…mize extension for each component's view. See related issue comment.
…ner referring. See issue Corviz#17 comment for more info.
… dashed attributes won't be camelCased anymore due to ability to user custom data attributes, also introduced $this->getAttributesParsed() passed through custom component by $attributesParsed.
Author
|
I've also fixed issue #11 and changed the behavior of parsing attributes: dashed attributes won't be camelCased anymore due to ability to user custom data attributes, also introduced |
Author
|
For the commit id <x-alert :level="$message->type == 'error' ? 'danger' : 'info'">
{{ $alertMessage }}
</x-alert>The solution is to use @php @endphp directives to store the variable to use it here. |
Author
|
Okay I've solved an issue: passing object or array as attribute parameter value in the custom component. |
…ableCodeMinifying()`
…ing `disableCodeMinifying()`" This reverts commit 7cb5372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I've discovered your repo while I'm looking for a powerful template engine for my new PHP MVC Framework. I really appreciate your effort to develop something like this!
During my testing, I've opened 13 issues to fix. As a thanks for you, I decided to say it on my way; I forked it and pushed my fixes and my special touches and ideas, you may review the seven closed issues on your repo to see what I'd done.
At the end, I tried to do my best to solve my all opened issues but I couldn't for now. However, I'll be happy to participate for any new ideas and fixes that you may need in the future.
Thanks for your effort to present this powerful framework.
[PS]: I've linted all files to reduce file sizes for a better stability and light loading.